Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization: menu items with "role" and auto-label do not change to locale other than OS lang #45

Open
danielweck opened this issue May 5, 2019 · 2 comments

Comments

@danielweck
Copy link
Member

Main app menu:
"About" menu (MacOS):

ace-gui/src/main/menu.js

Lines 320 to 345 in 1bc51e8

{
// label: localize('menu.services'),
id: 'services',
role: 'services',
submenu: []
},
{
type: 'separator'
},
{
// label: localize('menu.hideAce'),
id: 'hideAce',
// accelerator: 'Command+H',
role: 'hide'
},
{
// label: localize('menu.hideOthers'),
id: 'hideOthers',
// accelerator: 'Command+Alt+H',
role: 'hideothers'
},
{
// label: localize('menu.showAll'),
id: 'showAll',
role: 'unhide'
},

"Window" menu (all platforms):

ace-gui/src/main/menu.js

Lines 368 to 389 in 1bc51e8

{
// label: localize('menu.togglefullscreen'),
role: "togglefullscreen",
},
{
// label: localize('menu.minimize'),
id: 'minimize',
role: 'minimize'
},
{
role: "close",
},
// {
// label: 'Minimize',
// role: 'minimize'
// },
{ type: 'separator' },
{
// label: localize('menu.bringToFront'),
id: 'bringToFront',
role: 'front'
}

Knowledge Base window menu:
"About" menu (MacOS):

ace-gui/src/main/kb.js

Lines 372 to 397 in 1bc51e8

{
// label: localize('menu.services'),
id: 'services',
role: 'services',
submenu: []
},
{
type: 'separator'
},
{
// label: localize('menu.hideAce'),
id: 'hideAce',
// accelerator: 'Command+H',
role: 'hide'
},
{
// label: localize('menu.hideOthers'),
id: 'hideOthers',
// accelerator: 'Command+Alt+H',
role: 'hideothers'
},
{
// label: localize('menu.showAll'),
id: 'showAll',
role: 'unhide'
},

"Window" menu (all platforms):

ace-gui/src/main/kb.js

Lines 420 to 441 in 1bc51e8

{
// label: localize('menu.togglefullscreen'),
role: "togglefullscreen",
},
{
// label: localize('menu.minimize'),
id: 'minimize',
role: 'minimize'
},
{
role: "close",
},
// {
// label: 'Minimize',
// role: 'minimize'
// },
{ type: 'separator' },
{
// label: localize('menu.bringToFront'),
id: 'bringToFront',
role: 'front'
}

@danielweck
Copy link
Member Author

Related issue: #46
(possible solution?)

@danielweck
Copy link
Member Author

Electron menu roles:
https://electronjs.org/docs/api/menu-item#roles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant