Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptographic API Misuse Vulnerability #550

Open
lialon opened this issue Aug 7, 2024 · 0 comments
Open

Cryptographic API Misuse Vulnerability #550

lialon opened this issue Aug 7, 2024 · 0 comments

Comments

@lialon
Copy link

lialon commented Aug 7, 2024

Description:

In the "python-cwt/samples/eudcc/swedish_verifier.py" and "python-cwt/cwt/algs/rsa.py", I have identified security vulnerabilities about insecure cryptographic algorithm and insecure verification. PKCS1v1.5 is vulnerable to the chosen-ciphertext attack. And bypassing JWT verification or using JWT tokens before verification are considered insecure.

Location:

https://github.com/dajiaji/python-cwt/blob/main/cwt/algs/rsa.py#L57

self._padding = padding.PKCS1v15()

https://github.com/dajiaji/python-cwt/blob/main/samples/eudcc/swedish_verifier.py#L41

 decoded = jwt.decode(
            r.text,
            cose_key.key,
            algorithms=["ES256"],
            options={"verify_aud": False},
        )

Reference

  • CWE-780: Use of RSA Algorithm without OAEP
  • CWE-287: Improper Authentication

Recommendations:

  • Try using other padding(OAEP) instead of PKCS1v1.5.
  • There should be proper verification of JWT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant