Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: No 'Nasheed' Genre Auto-Skip Functionality #146

Open
ibrahimkettaneh opened this issue Feb 16, 2024 · 0 comments
Open
Labels
auto skip Regarding autoSkip extensions enhancement New feature or request

Comments

@ibrahimkettaneh
Copy link

ibrahimkettaneh commented Feb 16, 2024

Choose the extension for feature request.

Auto Skip

📝 Provide a description of the new feature

Proposal: Enhance auto-skip Spicetify extension with an auto-skip feature targeting tracks not labeled 'Nasheed'. This addition will streamline user experience by honoring genre preferences.

Sample Track: 'My Soul - Vocals Only Original'.

Your consideration of this request is greatly appreciated.

➕ Additional Information

I started working on implementing this and I would eagerly contribute based on your direction.

      skipNasheed: {
        menuTitle: "Nasheed Songs",
        check: (e) =>
          !e.name.toLowerCase().includes("nasheed"),
      },
diff --git a/autoSkip.js b/autoSkip.js
index 75c97cc..df9ebc7 100644
--- a/autoSkip.js
+++ b/autoSkip.js
@@ -42,10 +42,7 @@
     (u = {
       skipAcoustic: {
         menuTitle: "Acoustic Songs",
-        check: (t) =>
-          ["acoustic", "stripped", "unplugged"].some((e) =>
-            t.name.toLowerCase().includes(e),
-          ) || 0.85 < t?.features?.acousticness,
+        check: (t) => false,
         callback: async (e) => {
           await r(a(e.name) + " artist:" + e.artists[0].name);
         },
@@ -53,7 +50,7 @@
       skipNassheed: {
         menuTitle: "Nasheed Songs",
         check: (e) =>
-          e.name.toLowerCase().includes("nasheed"),
+          !e.name.toLowerCase().includes("nasheed"),
       },
       skipRemix: {
         menuTitle: "Remix Songs",
@ibrahimkettaneh ibrahimkettaneh added the enhancement New feature or request label Feb 16, 2024
@ibrahimkettaneh ibrahimkettaneh changed the title [Feature Request]: 'Nasheed' Genre Auto-Skip Functionality [Feature Request]: No 'Nasheed' Genre Auto-Skip Functionality Feb 16, 2024
@daksh2k daksh2k added the auto skip Regarding autoSkip extensions label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto skip Regarding autoSkip extensions enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants