Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 4.3+ binary export format #9

Open
funnbot opened this issue Aug 31, 2024 · 1 comment
Open

Support 4.3+ binary export format #9

funnbot opened this issue Aug 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@funnbot
Copy link

funnbot commented Aug 31, 2024

Just discovered this myself, the docs for EditorExportPlugin._get_name state

Return the name identifier of this plugin (for future identification by the exporter). The plugins are sorted by name before exporting. Implementing this method is required.

https://github.com/godotengine/godot/blob/61598c5c88d95b96811d386cb20d714c35f4c6d7/modules/gdscript/register_types.cpp#L120
the gdscript export plugin uses GDScript.

Fixing _get_name, and running before the .gd files are remapped to .gdc, should allow this addon to work.

@dalexeev dalexeev added the enhancement New feature or request label Aug 31, 2024
@dalexeev
Copy link
Owner

Hello, thank you for your interest and this proposal!

I have already seen the method. Unfortunately, this plugin is problematic to integrate into the standard GDScript export pipeline, since GDScript reads the source file from disk. I would not like to overwrite files on disk due to the risk of data loss. It would be more correct to first implement support on the GDScript side.

The only thing that export plugin sorting allows is to forcefully skip script conversion even in binary tokens export mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants