System text substitutions no longer working

[sebj]

The text substitutions in System Preferences => Keyboard => Text no longer work in the new message text field. I'm not entirely sure they worked in the old version of Goofy, but I could have sworn they did..

[MustafaHaddara]

They definitely worked in the old version. I'd guess that this is probably an Electron problem...they don't use the standard system stuff so all of the macOS specific functionality (ex. touch bar, text substitutions, spell check, etc.) is gone.

[RvMouche]

It's an electron problem indeed, see issues electron/electron#3211 and electron/electron#3210

I've found this: might be usable: https://github.com/hokein/electron-sample-apps/tree/master/spell-check. I thought spell-check and text substitutions are combined in macOS' API's. Unfortunately I don't have the time to try it myself and PR it.

[RvMouche]

If text substitutions aren't in the spell-check API, we can also use: https://github.com/CharlieHess/electron-text-substitutions .

[jklp]

Sorry I'm a little stumped with this one .. I added electron-text-substitutions though as part of the API I need to get the input field to decorate - but there doesn't seem to be an input field I can select as the input box is using a bunch of <spans> to render (it must be listening globally for keypresses or something?)

My JavaScript/DOM-fu isn't good enough to figure this out - if someone has a solution I'm all ears

[jklp]

Seems to be working since upgrading to Electron 7!

[jklp]

Weird, I've noticed some weird behaviour in the text replacement feature (sorry I didn't pick it up initially as I use another text substitution app (a-text) which masked the bug) where after substitution, it'd print both the original (un-replaced) text and the replaced text.

I checked on the latest build of Chrome and it looks like it's happening there too - so most likely a messenger.com bug - not a Goofy / Electron bug 😕

(btw, I noticed they're not using an HTML text field for input but a custom control - which makes it even harder to patch on the Goofy end)

[jklp]

Oof, this no longer works as had to revert to Electron 6 to get #471 working (I'd much rather have calls working again than text substitutions).

Wil leave this scheduled for the next milestone - hopefully either messenger.com or Electron 8 fix this problem, then we can have this working again in the next release.