You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
submitted pull request #42 to merge updated hdf5-phantom branch into master.
Before approving pull request, it should be checked that reading phantom hdf5 dumps returns the same arrays as reading the phantom binary dump. e.g. pxyzu from GR is currently not being read
see comments on #42, this code needs to be rewritten in c consistent with the other hdf5 readers in splash, and also needs to be written in a way that does not hard wire the dataset names in the hdf5 reader, so it does not need ongoing maintenance any time a new quantity is written by phantom. Sorry for not being clearer on requirements here in the first place.
this is needed, some work sitting in pull request
The text was updated successfully, but these errors were encountered: