Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splash reader for phantom-hdf5 files #25

Open
danieljprice opened this issue Feb 24, 2020 · 2 comments
Open

splash reader for phantom-hdf5 files #25

danieljprice opened this issue Feb 24, 2020 · 2 comments

Comments

@danieljprice
Copy link
Owner

this is needed, some work sitting in pull request

@dliptai
Copy link
Collaborator

dliptai commented Sep 2, 2020

submitted pull request #42 to merge updated hdf5-phantom branch into master.

Before approving pull request, it should be checked that reading phantom hdf5 dumps returns the same arrays as reading the phantom binary dump. e.g. pxyzu from GR is currently not being read

@danieljprice
Copy link
Owner Author

see comments on #42, this code needs to be rewritten in c consistent with the other hdf5 readers in splash, and also needs to be written in a way that does not hard wire the dataset names in the hdf5 reader, so it does not need ongoing maintenance any time a new quantity is written by phantom. Sorry for not being clearer on requirements here in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants