Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust paragraph-based modifications #145

Open
danielsaidi opened this issue Feb 18, 2024 · 2 comments
Open

Adjust paragraph-based modifications #145

danielsaidi opened this issue Feb 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@danielsaidi
Copy link
Owner

The following RichTextComponent set operations now use a shared paragraph setter, which will simplify things moving forward.

For now, setting these properties work when text is not selected, or if a single paragraph is selected. If multiple paragraphs are selected, only the first one is affected due to the lineRange check.

We should fix this before the 1.0 release @DominikBucher12
@danielsaidi danielsaidi added the bug Something isn't working label Feb 18, 2024
@danielsaidi danielsaidi added this to the 1.0 milestone Feb 18, 2024
@DominikBucher12
Copy link
Collaborator

#147 🎉

@DominikBucher12 DominikBucher12 mentioned this issue Feb 29, 2024
Open
@danielsaidi
Copy link
Owner Author

Let's fix this after 1.0.

@danielsaidi danielsaidi removed this from the 1.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielsaidi @DominikBucher12