Merging function get_keyword() and function keyword_count()

[splifingate]

It seems duplicitous, to me, that there would be two distinct functions() pertaining to a subjectively singular process.

Just trying to determine the reasons behind the separate functions(), and getting my mind around the idea of merging the two...

...could/should this be a Thing?

[danpros]

Yes we need to improve the search functions/functionality, previously we only search the title and tags based on the filename because I don't want to open each file to find the desired word. Imagine if we have 10K articles, opening 10K files one by one will definitely slow things down a lot.

I'm going to create some kind of new method for this. So it's almost similar to page views.

There is a kind of search index that contains each article content. When we create an article, update/edit/delete. We will automatically add this to the search index. We can also manually add this.

There are two options, search only title and tags, or title, tags and content (more RAM used).

[taufik-nurrohman]

The solution is to read the file line by line but not storing it into memory. Just check if a query is found in the string then stop the loop, continue to the next file ^{1 2}

if (is_file($path) && $h = fopen($path, 'r')) {
    while (false !== ($v = fgets($h, 4096)) {
        // Find the query in `$v`
        if (has_query_in_file_stream($v)) {
            add_file_path_to_queue($path);
            break;
        }
    }
    fclose($h);
}

Footnotes

1. https://github.com/mecha-cms/mecha/blob/v3.2.0/engine/f.php#L1410 ↩

2. https://github.com/mecha-cms/mecha/blob/v3.2.0/engine/f.php#L1142 ↩

[danpros]

@taufik-nurrohman Thanks for the reference.

For performance reasons it seems best to put the contents into a single file in json format (id => content), sure more RAM during read or update the index. I tried and for 150 articles between 300-500 words, the file created was around 400-600KB.

[taufik-nurrohman]

No problem. It seems that HTMLy is more into improving the performance by file cache (requires more storage) than leveraging the RAM (less storage). But I understand.