-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark plugin @threadSafe to comply with Maven 3.5.0 parallel execution #11
Comments
Hi, I will try to look at this. Are you able to help review the code for thread safety? That would help a lot. If you're feeling really keen, then a PR with the annotation in would give you all the kudos :) Also, it would be good to know if you're consuming the plugin via maven central, as I will need to fix the build/publishing as well if that's the case. Thanks. |
Hi @dantwining, |
@EHJ-52n @dantwining This is super easy PR. formatter-maven-pugin already has this so you can see it here. Since this plugin in my opinion is a really small subset of formatting, it is nothing to really test, just add the flag and move on. I can raise a PR. I'm looking to use this anyways for those that are not ready for full formatting as it does a minimum approach which is far less of a concern than full formatting. If this tests out fine for my needs, I'll fork and raise a PR here. |
@dantwining I'll take care of this one. I used your library on mybatis-3 and it worked really well. |
This is done on the fork and will be released today https://github.com/hazendaz/whitespace-maven-plugin |
When executing a parallel build with a
whitespace-maven-plugin
execution, Maven 3.5.0 will output a warningCan you add this please? Thank you very much.
The text was updated successfully, but these errors were encountered: