Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postal Code: data is not up-to-date #10

Closed
htdat opened this issue Sep 6, 2020 · 2 comments
Closed

Postal Code: data is not up-to-date #10

htdat opened this issue Sep 6, 2020 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@htdat
Copy link

htdat commented Sep 6, 2020

https://github.com/daohoangson/dvhcvn/blob/master/data/sorted.json
I know this is WIP #7

However, the source of data may not be correct?

For example: 50408 is for P. Phước Mỹ - Sơn Trà - Đà Nẵng.
Source: http://dmdc.ngsp.gov.vn/WebPortal/Detail?CategoryId=85e7cbfa-40ed-4379-b010-943a31e5c898&ValueId=ac43ba8c-63f0-4bd3-948b-ff4ce19a15d4&ParrentPageRedirect=1&PageIndex=0

Another source: http://mabuuchinh.vn/default.aspx?page=SearchMBC

sorted.json file above is showing:

                    ["20275", "Phước Mỹ", "Phường", "Phuoc My"],
@daohoangson daohoangson self-assigned this Sep 6, 2020
@daohoangson daohoangson added the documentation Improvements or additions to documentation label Sep 6, 2020
@daohoangson
Copy link
Owner

The postcode data is not ready so it's in its own file. Also, the branch is not merged yet so it is currently here:

https://github.com/daohoangson/dvhcvn/blob/postcode/data/postcode.json

20275 is the administrative unit ID. You will find the postcode by looking for that ID.

Screen Shot 2020-09-06 at 4 26 42 PM

-> postcode for ID 20275 (Phường Phước Mỹ) is 50408.

I have some clean up to do. Afterwards, postcode will be included in the sorted.json file.

@htdat
Copy link
Author

htdat commented Sep 6, 2020

Aha, that makes sense!

@htdat htdat closed this as completed Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants