Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase contrast of search term [UI] #4

Open
alltheseas opened this issue Apr 7, 2023 · 1 comment
Open

Increase contrast of search term [UI] #4

alltheseas opened this issue Apr 7, 2023 · 1 comment

Comments

@alltheseas
Copy link
Contributor

Mockup:

boldpurple

@darashi
Copy link
Owner

darashi commented Apr 7, 2023

It would be nice to have this, but it does not seem to be that easy to implement properly.

The first reason is that the query is interpreted by the NIP-50 relay, not always as an exact match. For example, my implementation, search.nos.today treats the query as a space-separated AND search (Symbols may be dropped. Details depend on Elasticsearch). If approximations are good enough, we might be able to work around it.

Now that we have determined which strings should be highlighted, there is another problem. This is an implementation problem. It does not seem to be that easy to highlight while taking into account the nesting of tags. There may be cases where it is necessary to highlight across the boundaries of tags that already exist.

So, I think it would be nice to have it, but may not be able to implement it right away. I will continue to think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants