From e0e59e1047e838dc1a44bd58aac0fc0cfc0d3bc6 Mon Sep 17 00:00:00 2001 From: Dean Attali Date: Sun, 12 Jun 2016 21:17:53 -0700 Subject: [PATCH] make sure all apps using shinyjs work without requiring V8 --- close-window/app.R | 6 +++--- multiple-scrollspy-advanced/app.R | 2 +- multiple-scrollspy-basic/app.R | 2 +- navigate-history/app.R | 2 +- serve-images-files/app.R | 2 +- update-input/app.R | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/close-window/app.R b/close-window/app.R index 8fae3a6..dea56e3 100644 --- a/close-window/app.R +++ b/close-window/app.R @@ -1,15 +1,15 @@ library(shinyjs) -jscode <- "shinyjs.closewindow = function() { window.close(); }" +jscode <- "shinyjs.closeWindow = function() { window.close(); }" ui <- fluidPage( useShinyjs(), - extendShinyjs(text = jscode), + extendShinyjs(text = jscode, functions = c("closeWindow")), actionButton("close", "Close window") ) server <- function(input, output, session) { observeEvent(input$close, { - js$closewindow() + js$closeWindow() stopApp() }) } diff --git a/multiple-scrollspy-advanced/app.R b/multiple-scrollspy-advanced/app.R index 7eb9a9b..f4a5d80 100644 --- a/multiple-scrollspy-advanced/app.R +++ b/multiple-scrollspy-advanced/app.R @@ -6,7 +6,7 @@ ui <- navbarPage( id = "navbar", header = div( useShinyjs(), - extendShinyjs("www/app-shinyjs.js"), + extendShinyjs("www/app-shinyjs.js", functions = c("updateScrollspy")), includeCSS("www/app.css"), includeScript("https://cdnjs.cloudflare.com/ajax/libs/jquery-scrollTo/1.4.3/jquery.scrollTo.min.js") ), diff --git a/multiple-scrollspy-basic/app.R b/multiple-scrollspy-basic/app.R index e8a2f5c..36e7268 100644 --- a/multiple-scrollspy-basic/app.R +++ b/multiple-scrollspy-basic/app.R @@ -7,7 +7,7 @@ ui <- navbarPage( header = div( useShinyjs(), - extendShinyjs("www/app-shinyjs.js"), + extendShinyjs("www/app-shinyjs.js", functions = c("updateScrollspy")), includeCSS("www/app.css"), # create a common scrollspy diff --git a/navigate-history/app.R b/navigate-history/app.R index a1258a4..c5509b2 100644 --- a/navigate-history/app.R +++ b/navigate-history/app.R @@ -6,7 +6,7 @@ ui <- navbarPage( id = "navbar", header = tagList( useShinyjs(), - extendShinyjs("www/app-shinyjs.js") + extendShinyjs("www/app-shinyjs.js", functions = c("updateHistory")) ), tabPanel("Home", value = "home", diff --git a/serve-images-files/app.R b/serve-images-files/app.R index f1fd65d..65848aa 100644 --- a/serve-images-files/app.R +++ b/serve-images-files/app.R @@ -10,7 +10,7 @@ shinyjs.navigate = function(url) { ui <- fluidPage( useShinyjs(), - extendShinyjs(text = jscode), + extendShinyjs(text = jscode, functions = c("navigate")), # Portion of the app that lets the user cutomize a plot and then see # a URL to serve that plot diff --git a/update-input/app.R b/update-input/app.R index 92fda81..2794685 100644 --- a/update-input/app.R +++ b/update-input/app.R @@ -5,7 +5,7 @@ source("update-input.R") ui <- fluidPage( useShinyjs(), - extendShinyjs("www/app-shinyjs.js"), + extendShinyjs("www/app-shinyjs.js", functions = c("getInputType")), textInput("text", "Text input", "some text"), selectInput("select", "Select input", LETTERS),