Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when creating new orders #14

Open
Trader12345a opened this issue Aug 24, 2020 · 7 comments
Open

Error when creating new orders #14

Trader12345a opened this issue Aug 24, 2020 · 7 comments

Comments

@Trader12345a
Copy link

I keep getting the below error when attempting to add new orders:

abs(quot - round(quot)) < 1e-10 is not TRUE

Does anyone know how to solve this issue?

@Trader12345a
Copy link
Author

Trader12345a commented Aug 24, 2020

On further inspection, the error I think is caused by

quot <- (quantity - filters[filterType == 'MARKET_LOT_SIZE', minQty]) / filters[filterType == 'MARKET_LOT_SIZE', stepSize]

in your code. For some pairs the "stepsize" is 0, so it is trying to divide by zero. Can you update the code so that if the stepsize is zero, all positive numbers are allowed as quantities?

@yapchunkee
Copy link

I believe this issue can be solved by

quot <- (quantity - filters[filterType == 'LOT_SIZE', minQty]) / filters[filterType == 'LOT_SIZE', stepSize]

@DataStrategist
Copy link

Hi all. Just running into this problem. @Trader12345a and @yapchunkee , do either of you have forks w/ this problem fixed?

Thanks!

DataStrategist added a commit to DataStrategist/binancer that referenced this issue Feb 25, 2021
@daroczig
Copy link
Owner

Hey @madsurgeon, any chance you might remember what's going on at https://github.com/daroczig/binancer/blob/master/R/binance.R#L761 and what would be your suggestion to overcome the Inf issue?

@madsurgeon
Copy link
Contributor

Thanks for letting me know @daroczig !
I looked at it and it's clear. I will make a PR and fix it.

@vvkorotkikh
Copy link

Thanks for letting me know @daroczig ! I looked at it and it's clear. I will make a PR and fix it.

Is there any ideas of fix this issue? It still returns error when attempting to add new orders.

@mvdv1234
Copy link

Thanks for letting me know @daroczig ! I looked at it and it's clear. I will make a PR and fix it.

Is there any ideas of fix this issue? It still returns error when attempting to add new orders.

Did anyone here found out how to fix it? Because when opening a market order the error still appears. I tried to dowload the latest version from the binacer package from github but the error still appears. Would be great if you guys can help me out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants