Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support API of USDM futures #21

Open
siegfried opened this issue Dec 17, 2021 · 5 comments
Open

Support API of USDM futures #21

siegfried opened this issue Dec 17, 2021 · 5 comments

Comments

@siegfried
Copy link

Does this project accepts features of USDM? Shall I add them to binance.R or a new file?

@daroczig
Copy link
Owner

I am not familiar with the USDM features, but based on a quick search, I think it would be a great extension, so looking forward to any help 🙇

binance.R grew super large already (it was named that way as originally this package supported multiple crypto exchanges), so feel free to start a new file.

Thanks!

@siegfried
Copy link
Author

siegfried commented Dec 17, 2021

I think binance_query() is reusable. For most of the API on USDM we just need to point the host to https://fapi.binance.com. I can make the base here as an argument.
However, for functions like binance_new_order() need new counterparts since the orders on USDM are different. What do you propose the function names would be? Shall I rename the current spot specific functions and move them to a different file?

base = 'https://api.binance.com',

@siegfried
Copy link
Author

siegfried commented Dec 20, 2021

May I use tibble of dplyr instead of data.table in this project? @daroczig

@daroczig
Copy link
Owner

Sorry, I'd rather not mix dplyr and data.table in the same project.

On the other hand, if you are asking about the user-facing result, I've done this on a configurable way in another project of mine https://github.com/daroczig/dbr/blob/master/R/db.R#L131-L137

@siegfried
Copy link
Author

It's fine. I don't want to mix them either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants