Try to make a genuine test fail

[pythcoiner]

          > or i miss something

Yes. :) If the device fails the check, the Ledger API would return an error (well, i hope, i guess we could test this by messing with the data transmitted) and query_via_websocket would propagate this error:

ledger_installer/ledger_manager/src/lib.rs

Lines 370 to 375 in 7be54a5

	} else if msg.query == "success" {
	return Ok(());
	} else if msg.query == "error" {
	return Err(
	format!("Got an 'error' query on the ws. Full message: {}.", text).into(),
	);

Originally posted by @darosior in #5 (comment)

[pythcoiner]

@darosior should we then change the return type of genuine_check() from

Result<(), Box<dyn error::Error>> 
       ^^

to

Result<bool, Box<dyn error::Error>>
       ^^^^ 

?

[darosior]

Why? When would the function ever return false?

…

On Tuesday, May 7th, 2024 at 11:25 AM, pythcoiner ***@***.***> wrote: ***@***.***(https://github.com/darosior) should we then change the return type of genuine_check() from Result<(), Box<dyn error::Error>> ^^ to Result<bool, Box<dyn error::Error>> ^^^^ ? — Reply to this email directly, [view it on GitHub](#6 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3FYQMLCEZPTNLSKAF2TZBCMY3AVCNFSM6AAAAABHKSVVTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXHA2TAMBTGM). You are receiving this because you were mentioned.Message ID: ***@***.***>

[pythcoiner]

when the device is not genuine, but yeah the function is genuine_check() and not is_genuine() so your way makes sense

[darosior]

If it's not genuine an error is returned already.

…

On Tuesday, May 7th, 2024 at 12:52 PM, pythcoiner ***@***.***> wrote: when the device is not genuine — Reply to this email directly, [view it on GitHub](#6 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AFLK3FYFNYHSGHLCCCGYCDDZBCXANAVCNFSM6AAAAABHKSVVTWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGA4DAMJRGM). You are receiving this because you were mentioned.Message ID: ***@***.***>