From 9950eff55446a7c091f266d66716c407ea5d5a1e Mon Sep 17 00:00:00 2001 From: Victor Berchet Date: Thu, 31 Jul 2014 16:41:14 +0200 Subject: [PATCH] fix(HttpConfig): Remove the optional argument to the default ctor Because this is not currently supported by the Dependency injection. A new HttpConfig.withOptions() ctor has been added. --- lib/core_dom/http.dart | 4 +++- lib/core_dom/module_internal.dart | 2 +- test/core_dom/http_spec.dart | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/core_dom/http.dart b/lib/core_dom/http.dart index 0cc6ae918..4beb459f8 100644 --- a/lib/core_dom/http.dart +++ b/lib/core_dom/http.dart @@ -755,5 +755,7 @@ class Http { class HttpConfig { final Duration coalesceDuration; - HttpConfig({this.coalesceDuration}); + HttpConfig(): coalesceDuration = null; + + HttpConfig.withOptions({this.coalesceDuration}); } diff --git a/lib/core_dom/module_internal.dart b/lib/core_dom/module_internal.dart index e599d30ae..5c809c18c 100644 --- a/lib/core_dom/module_internal.dart +++ b/lib/core_dom/module_internal.dart @@ -86,7 +86,7 @@ class CoreDomModule extends Module { bind(HttpDefaultHeaders); bind(HttpDefaults); bind(HttpInterceptors); - bind(HttpConfig, toValue: new HttpConfig()); + bind(HttpConfig); bind(Animate); bind(ViewCache); bind(BrowserCookies); diff --git a/test/core_dom/http_spec.dart b/test/core_dom/http_spec.dart index 95a3a2805..edcf2222b 100644 --- a/test/core_dom/http_spec.dart +++ b/test/core_dom/http_spec.dart @@ -1426,8 +1426,8 @@ void main() { describe('coalesce', () { beforeEachModule((Module module) { - var coalesceDuration = new Duration(milliseconds: 100); - module.bind(HttpConfig, toValue: new HttpConfig(coalesceDuration: coalesceDuration)); + var duration = new Duration(milliseconds: 100); + module.bind(HttpConfig, toValue: new HttpConfig.withOptions(coalesceDuration: duration)); }); it('should coalesce requests', async((Http http) {