-
Notifications
You must be signed in to change notification settings - Fork 29
maybeEmitFakeConstructor
considered harmful
#82
Comments
cc/ @natebosch who knows way more about this than I do. |
This is a PR where the autogenerated code had to be removed: flutter/plugins#2602 |
I have never seen the errors this code claims to solve. @jacob314 - do you know the specifics? How can I repro? My first preference would be to remove this altogether, I don't understand the problem it solves. If we can't remove this altogether we can consider adding an |
they were never intended to be called. They were only around to placate the anlayzer for the hard to predict cases where you had a sublcass with a constructor but the base class didn't have the appropriate constructor. I forget the exact details. |
Let's drop them. I haven't seen a case where they are necessary. If someone complains we can revisit. |
sgtm |
I can get this done tomorrow. I think I'm one of the main users of the script for now :P |
Happy to review any PR requests you send my way :) |
Generated
fakeConstructor$
do not work and can't be called in dart2js, hence they probably shouldn't be generated anymore.This should be removed.
The text was updated successfully, but these errors were encountered: