Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that TFA inferred types are as specific as Dart types #55828

Open
osa1 opened this issue May 23, 2024 · 0 comments
Open

Verify that TFA inferred types are as specific as Dart types #55828

osa1 opened this issue May 23, 2024 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request triaged Issue has been triaged by sub team type-enhancement A request for a change that isn't a bug vm-tfa

Comments

@osa1
Copy link
Member

osa1 commented May 23, 2024

It would be helpful, for catching any bugs in TFA's inferred types, if we could verify that TFA always infers more precise types than the Dart types of analyzed members.

For example, if the Dart return type of a member is Object, it's valid to infer the actual return type of it as int, but it's invalid (a bug in TFA) to infer it as Object?.

This would catch bugs like flutter/flutter#148617 (comment), and maybe also help improve inferred types in cases like #53921 (comment).

cc @alexmarkov
@osa1 osa1 added the vm-tfa label May 23, 2024
@alexmarkov alexmarkov added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug triaged Issue has been triaged by sub team labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. P3 A lower priority bug or feature request triaged Issue has been triaged by sub team type-enhancement A request for a change that isn't a bug vm-tfa
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@osa1 @alexmarkov