Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] Fix WASM error caused by incorrect return type #55837

Closed
alexmarkov opened this issue May 24, 2024 · 6 comments
Closed

[CP] Fix WASM error caused by incorrect return type #55837

alexmarkov opened this issue May 24, 2024 · 6 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-dart2wasm Issues for the dart2wasm compiler. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@alexmarkov
Copy link
Contributor

Commit(s) to merge

345b437

Target

beta

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/368180

Issue Description

WebAssembly error

Uncaught (in promise) CompileError: WebAssembly.compileStreaming(): Compiling function #1263:"identityHashCode" failed: type error in return[0] (expected i64, got (ref null 103)) @+1479968

was caused by the incorrect return type generated by dart2wasm.

What is the fix

TFA was fixed to avoid inferring nullable return types for methods with non-nullable static return types.

Why cherry-pick

This bug prevents running an app on WASM.

Risk

Low

Issue link(s)

flutter/flutter#148617

Extra Info

No response
@alexmarkov alexmarkov added the cherry-pick-review Issue that need cherry pick triage to approve label May 24, 2024
@alexmarkov alexmarkov added the area-dart2wasm Issues for the dart2wasm compiler. label May 24, 2024
@alexmarkov
Copy link
Contributor Author

/cc @mkustermann @mraleph

@alexmarkov alexmarkov mentioned this issue May 24, 2024
Closed
@mkustermann
Copy link
Member

LGTM

@athomas athomas added the cherry-pick-approved Label for approved cherrypick request label May 28, 2024
@mkustermann
Copy link
Member

@athomas @alexmarkov Can we rather cherry-pick this to stable?

@mkustermann
Copy link
Member

@athomas @alexmarkov Can we rather cherry-pick this to stable?

Never mind. The stable branch is from march (we only started using this TFA information recently).

@mkustermann
Copy link
Member

As alex is OOO, I've +2'ed the change. This CP has landed on beta.

@athomas
Copy link
Member

athomas commented Jun 3, 2024

Released in 3.5.0-180.2.beta.

@athomas athomas closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-dart2wasm Issues for the dart2wasm compiler. cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@vsmenon @mkustermann @itsjustkevin @mit-mit @athomas @alexmarkov