Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline method nor working #59958

Open
stephane-archer opened this issue Jan 22, 2025 · 0 comments
Open

inline method nor working #59958

stephane-archer opened this issue Jan 22, 2025 · 0 comments
Labels
analyzer-refactoring analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@stephane-archer
Copy link

stephane-archer commented Jan 22, 2025

void foo () async {
          await lutFoldersNotifier.addLutDirWithFilePicker();
}

class LutFoldersNotifier extends AsyncNotifier<LutFoldersState> {
  final PersistentLutFoldersSet _persistentLutFoldersSet =
      PersistentLutFoldersSet();

  Future<void> addLutDirWithFilePicker() async {
    final String? selectedDirectory =
        await FilePicker.platform.getDirectoryPath();
    if (selectedDirectory == null) {
      // User canceled the picker
      return;
    }
    await addLutDir(selectedDirectory);
  }

  Future<void> addLutDir(String selectedDirectory) async {
...
}
}

inline method on await lutFoldersNotifier.addLutDirWithFilePicker();
produced code:

           await lutFoldersNotifier.() async {
            final String? selectedDirectory =
                await FilePicker.platform.getDirectoryPath();
            if (selectedDirectory == null) {
              // User canceled the picker
              return;
            }
            await addLutDir(selectedDirectory);
          }();

expected code:

          final String? selectedDirectory =
              await FilePicker.platform.getDirectoryPath();
          if (selectedDirectory == null) {
            // User canceled the picker
            return;
          }
          await lutFoldersNotifier.addLutDir(selectedDirectory);
@stephane-archer stephane-archer added the area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. label Jan 22, 2025
@bwilkerson bwilkerson added analyzer-server analyzer-refactoring P2 A bug or feature request we're likely to work on labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-refactoring analyzer-server area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

2 participants