-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request: make BuildImporter a public API #41
Comments
I'm not opposed to the idea, but I am more curious why you are not just using the exposed builder? |
The reason is that I'm compiling inline Sass inside of the Vue templates, e.g.: <style scoped lang="scss">
/* etc */
</style> |
I am reluctant to expose it since it will legitimize adding a dependency on sass_builder for packages that only want to reuse the Importer. By adding the dependency you are signalling to build_runner to automatically run sass_builder on your package during the build which might unnecessarily add to the build time. Line 5 in 888e8b2
I'm still thinking about how we should handle this. Maybe we should expose the Importer in a different package. |
I'm thinking for now that if we move it out of lib/src we just recommend that anyone depending on the package just to import that file should disable the sass_builder on their package. Does that make sense? Something like: targets:
vue:
...
builders:
sass_builder|sass_builder:
enabled: False |
Honestly, I think that would be entirely fine. Realistically I have no doubt that a bunch of VueDart projects will end up using Sass anyway... |
I want to add Sass support to VueDart 0.4, and right now I'm importing this project's BuildImporter, even though it's technically private
please don't kill me. However, I figured this might be something other projects may want, too, so I was wondering what the chances would be to make BuildImporter "officially" public...The text was updated successfully, but these errors were encountered: