Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockFactory needed for tests #121

Open
flavens opened this issue Dec 9, 2019 · 1 comment
Open

MockFactory needed for tests #121

flavens opened this issue Dec 9, 2019 · 1 comment
Assignees
@tobiasschweizer
Labels
enhancement Improve existing code or new feature
Milestone
Backlog

Comments

@flavens
Copy link
Contributor

flavens commented Dec 9, 2019

a MockFactory is needed at least for the tests in Knora-ui modules to be able to get test data, get mocked objects (especially complex ones like ReadDateValue and ReadGeomValue)
@flavens flavens added the enhancement Improve existing code or new feature label Dec 9, 2019
@flavens flavens mentioned this issue Dec 10, 2019
Merged
@tobiasschweizer
Copy link
Contributor

I will have to think of a way to make this possible without integrating test data in the published version.

@tobiasschweizer tobiasschweizer mentioned this issue Dec 10, 2019
Closed
@subotic subotic added this to the Backlog milestone Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiasschweizer tobiasschweizer

Labels
enhancement Improve existing code or new feature
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Export mock factory and test data dasch-swiss/dsp-js-lib
3 participants
@subotic @tobiasschweizer @flavens