From 20352269e7a3cee9335914c1dfc4c7bbde323ab4 Mon Sep 17 00:00:00 2001 From: Anton Suprunchuk Date: Thu, 3 Jun 2021 14:33:03 +0300 Subject: [PATCH] feat: change an order of error check to provide better and faster debug info (#129) --- test/e2e/dpns.spec.js | 10 +++++----- test/functional/platform/Document.spec.js | 6 +++--- test/functional/platform/Identity.spec.js | 12 ++++++------ 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/test/e2e/dpns.spec.js b/test/e2e/dpns.spec.js index 34f291ac..1c67e246 100644 --- a/test/e2e/dpns.spec.js +++ b/test/e2e/dpns.spec.js @@ -90,8 +90,8 @@ describe('DPNS', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.equal(2); expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Action is not allowed'); + expect(broadcastError.code).to.equal(2); expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError'); expect(broadcastError.data.errors[0].message).to.equal('Action is not allowed'); }); @@ -108,8 +108,8 @@ describe('DPNS', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.equal(2); expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Action is not allowed'); + expect(broadcastError.code).to.equal(2); expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError'); expect(broadcastError.data.errors[0].message).to.equal('Action is not allowed'); }); @@ -136,8 +136,8 @@ describe('DPNS', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.equal(2); expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Can\'t create top level domain for this identity'); + expect(broadcastError.code).to.equal(2); expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError'); expect(broadcastError.data.errors[0].message).to.equal('Can\'t create top level domain for this identity'); }); @@ -215,8 +215,8 @@ describe('DPNS', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.equal(2); expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Action is not allowed'); + expect(broadcastError.code).to.equal(2); expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError'); expect(broadcastError.data.errors[0].message).to.equal('Action is not allowed'); }); @@ -233,8 +233,8 @@ describe('DPNS', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.equal(2); expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Action is not allowed'); + expect(broadcastError.code).to.equal(2); expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError'); expect(broadcastError.data.errors[0].message).to.equal('Action is not allowed'); }); diff --git a/test/functional/platform/Document.spec.js b/test/functional/platform/Document.spec.js index 93054968..8b6e4470 100644 --- a/test/functional/platform/Document.spec.js +++ b/test/functional/platform/Document.spec.js @@ -82,8 +82,8 @@ describe('Platform', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.be.equal(3); expect(broadcastError.message).to.be.equal('State Transition is invalid: InvalidDocumentTypeError: Contract doesn\'t contain type undefinedType'); + expect(broadcastError.code).to.be.equal(3); const [error] = broadcastError.data.errors; expect(error.name).to.equal('InvalidDocumentTypeError'); }); @@ -153,8 +153,8 @@ describe('Platform', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.be.equal(2); expect(broadcastError.message).to.be.equal('Invalid state transition: DuplicateDocumentError: Duplicate Document found'); + expect(broadcastError.code).to.be.equal(2); const [error] = broadcastError.data.errors; expect(error.name).to.equal('DuplicateDocumentError'); @@ -287,8 +287,8 @@ describe('Platform', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.be.equal(2); expect(broadcastError.message).to.be.equal('Invalid state transition: DocumentTimestampWindowViolationError: Document createdAt timestamp are out of block time window and 2 more'); + expect(broadcastError.code).to.be.equal(2); const [error] = broadcastError.data.errors; expect(error.name).to.equal('DocumentTimestampWindowViolationError'); diff --git a/test/functional/platform/Identity.spec.js b/test/functional/platform/Identity.spec.js index f4fb6abb..06f5ac54 100644 --- a/test/functional/platform/Identity.spec.js +++ b/test/functional/platform/Identity.spec.js @@ -77,8 +77,8 @@ describe('Platform', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.be.equal(3); expect(broadcastError.message).to.be.equal('State Transition is invalid: InvalidIdentityAssetLockProofSignatureError: Invalid Asset lock proof signature'); + expect(broadcastError.code).to.be.equal(3); const [error] = broadcastError.data.errors; expect(error.name).to.equal('InvalidIdentityAssetLockProofSignatureError'); }); @@ -132,8 +132,8 @@ describe('Platform', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.be.equal(3); expect(broadcastError.message).to.be.equal('State Transition is invalid: IdentityAssetLockTransactionOutPointAlreadyExistsError: Asset lock transaction outPoint already exists'); + expect(broadcastError.code).to.be.equal(3); const [error] = broadcastError.data.errors; expect(error.name).to.equal('IdentityAssetLockTransactionOutPointAlreadyExistsError'); }); @@ -175,8 +175,8 @@ describe('Platform', () => { expect(broadcastError).to.exist(); - expect(broadcastError.code).to.be.equal(2); expect(broadcastError.message).to.be.equal('Invalid state transition: IdentityPublicKeyAlreadyExistsError: Identity public key already exists'); + expect(broadcastError.code).to.be.equal(2); const [error] = broadcastError.data.errors; expect(error.name).to.equal('IdentityPublicKeyAlreadyExistsError'); expect(Buffer.from(error.publicKeyHash)).to.deep.equal(identity.getPublicKeyById(0).hash()); @@ -352,8 +352,8 @@ describe('Platform', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.be.equal(9); expect(broadcastError.message).to.be.equal('Failed precondition: Not enough credits'); + expect(broadcastError.code).to.be.equal(9); }); it.skip('should fail top-up if instant lock is not valid', async () => { @@ -391,8 +391,8 @@ describe('Platform', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.be.equal(3); expect(broadcastError.message).to.be.equal('State Transition is invalid: InvalidIdentityAssetLockProofSignatureError: Invalid Asset lock proof signature'); + expect(broadcastError.code).to.be.equal(3); const [error] = broadcastError.data.errors; expect(error.name).to.equal('IdentityAssetLockTransactionNotFoundError'); }); @@ -473,8 +473,8 @@ describe('Platform', () => { } expect(broadcastError).to.exist(); - expect(broadcastError.code).to.be.equal(3); expect(broadcastError.message).to.be.equal('State Transition is invalid: IdentityAssetLockTransactionOutPointAlreadyExistsError: Asset lock transaction outPoint already exists'); + expect(broadcastError.code).to.be.equal(3); const [error] = broadcastError.data.errors; expect(error.name).to.equal('IdentityAssetLockTransactionOutPointAlreadyExistsError'); });