Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include without quoted filename misbehaving #113

Open
andrew-davie opened this issue Mar 1, 2021 · 1 comment
Open

include without quoted filename misbehaving #113

andrew-davie opened this issue Mar 1, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@andrew-davie
Copy link
Member

If you include a file without quotes surrounding the filename, dasm does actually include the file correctly...
but it also lists the filename as an unresolved symbol.
The manual, and here I'm being a bit self-referential, specifies that the include uses quotes around the name. Or more specifically it does not list the format without quotes.
My preference is to require quotes and flag non-quotes as an error... but this would probably break a lot of stuff.
The next best is to fix things up so that includes without quotes do not generate "unresolved symbol" warnings.

--- Unresolved Symbol List
NO_ILLEGAL_OPCODES       0000 ????         (R )
vcs.h                    0000 ????         (R )
RowGfx.h                 0000 ????         (R )
macro.h                  0000 ????         (R )
Colors.h                 0000 ????         (R )
--- 5 Unresolved Symbols

It's pretty clear what the includes were.
One argument for requiring quotes - let's say I had a weird filename like + (the symbol + without anything else). In this case

   include +

Will fail with an error, whereas the quoted form will work just fine.
Another way of saying this, it seems that dasm is parsing the line without quotes as if the parameter was a symbol, and so it is thus required to obey symbol syntax/rules -- which is definitely not the case with filenames.

So, I believe this is an issue that needs addressing as a bug, not just lacking documentation.

@thrust26 thrust26 added the enhancement New feature or request label Apr 13, 2021
@thrust26
Copy link
Member

If you include a file without quotes surrounding the filename, dasm does actually include the file correctly...
but it also lists the filename as an unresolved symbol.

This does not happen for me (Win10) anymore(?). Has this been fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants