From d673bd427aa59a869e139a02d7fddc9932a36e9c Mon Sep 17 00:00:00 2001 From: dlpzx <71252798+dlpzx@users.noreply.github.com> Date: Fri, 12 Jan 2024 16:20:10 +0100 Subject: [PATCH] Add word-wrap in strings in share lists (#972) ### Feature or Bugfix - Bugfix ### Detail - Add word wrap around strings to force wrapping with no break chars in Share list. The issue and alternatives are better explained in #971 After this PR, the UI in Share list looks like this for very long strings: ![image](https://github.com/data-dot-all/dataall/assets/71252798/7329855b-b3c6-49ed-afbc-8a2dd9b02126) ### Relates - #971 ### Security Please answer the questions below briefly where applicable, or write `N/A`. Based on [OWASP 10](https://owasp.org/Top10/en/). - Does this PR introduce or modify any input fields or queries - this includes fetching data from storage outside the application (e.g. a database, an S3 bucket)? - Is the input sanitized? - What precautions are you taking before deserializing the data you consume? - Is injection prevented by parametrizing queries? - Have you ensured no `eval` or similar functions are used? - Does this PR introduce any functionality or component that requires authorization? - How have you ensured it respects the existing AuthN/AuthZ mechanisms? - Are you logging failed auth attempts? - Are you using or adding any cryptographic features? - Do you use a standard proven implementations? - Are the used keys controlled by the customer? Where are they stored? - Are you introducing any new policies/roles/users? - Have you used the least-privilege principle? How? By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --- .../Shares/components/ShareBoxListItem.js | 38 +++++++++++++------ 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/frontend/src/modules/Shares/components/ShareBoxListItem.js b/frontend/src/modules/Shares/components/ShareBoxListItem.js index 96dc241e3..2788c34b7 100644 --- a/frontend/src/modules/Shares/components/ShareBoxListItem.js +++ b/frontend/src/modules/Shares/components/ShareBoxListItem.js @@ -17,7 +17,7 @@ export const ShareBoxListItem = ({ share }) => { }} > - + { - + { Request owner - + {`${share.principal.SamlGroupName}`} - + { IAM role name - + {`${share.principal.principalIAMRoleName}`} - + { Dataset - + {`${share.dataset.datasetName}`} - + { px: 3 }} > - + Dataset Owner @@ -92,7 +108,7 @@ export const ShareBoxListItem = ({ share }) => { - + - + {share.statistics.sharedItems > 0 && (