Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Manifest Service #500

Open
a-stacey opened this issue Jul 10, 2019 · 2 comments
Open

Create Manifest Service #500

a-stacey opened this issue Jul 10, 2019 · 2 comments

Comments

@a-stacey
Copy link
Contributor

No description provided.

@a-stacey
Copy link
Contributor Author

a-stacey commented Jul 10, 2019

For an MVP implementation we have decided that we will implment the manifest service as a separate service that sits along side the SCS and is access controlled via the EDAPI.

This will require a service with the following two end points for the MVP implementation:

  1. Find manifests by EventID returning a [Tree] where the Tree is the manifest data.
  2. Append to manifest using Signature as the primary key.

@a-stacey
Copy link
Contributor Author

I think that when we create endpoint 2 described above that the endpoint should validate that the signature is valid which it can do because it can connect out to the OrgRegistry and get the public key for the corresponding GLN and then verify that the sig checks out.

a-stacey added a commit that referenced this issue Jul 15, 2019
a-stacey added a commit that referenced this issue Jul 15, 2019
a-stacey added a commit that referenced this issue Jul 16, 2019
a-stacey added a commit that referenced this issue Jul 16, 2019
a-stacey added a commit that referenced this issue Jul 16, 2019
a-stacey added a commit that referenced this issue Jul 17, 2019
a-stacey added a commit that referenced this issue Jul 17, 2019
…py pasting code from the OR to initalise the Trails Service.

This issue was identified in code review.
a-stacey added a commit that referenced this issue Jul 22, 2019
This issue was identified in code review, based on discussion #509 (comment).
a-stacey added a commit that referenced this issue Jul 22, 2019
a-stacey added a commit that referenced this issue Jul 22, 2019
a-stacey added a commit that referenced this issue Jul 29, 2019
a-stacey added a commit that referenced this issue Jul 29, 2019
a-stacey added a commit that referenced this issue Jul 31, 2019
…wing to give a more intuative trail entry time ordering expectation.

I still don't love this nomenclature because really "previous" means "previous entry" but that would be to verbose and so it doesn't fit, but previously it was getting confusing which direction was parent and child.
a-stacey added a commit that referenced this issue Jul 31, 2019
a-stacey added a commit that referenced this issue Jul 31, 2019
…s-haskel so that they can be used across services.
a-stacey added a commit that referenced this issue Aug 14, 2019
a-stacey added a commit that referenced this issue Aug 19, 2019
a-stacey added a commit that referenced this issue Aug 19, 2019
a-stacey added a commit that referenced this issue Aug 19, 2019
a-stacey added a commit that referenced this issue Aug 19, 2019
a-stacey added a commit that referenced this issue Aug 19, 2019
a-stacey added a commit that referenced this issue Aug 19, 2019
a-stacey added a commit that referenced this issue Aug 19, 2019
a-stacey added a commit that referenced this issue Aug 21, 2019
…s of tests and correct where they don't.

Have left the debbuging print statements for future use as this has to be a manual process.
a-stacey added a commit that referenced this issue Aug 26, 2019
a-stacey added a commit that referenced this issue Aug 26, 2019
This recommendation was made in code review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant