Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate common code between services #533

Open
a-stacey opened this issue Sep 16, 2019 · 0 comments
Open

Deduplicate common code between services #533

a-stacey opened this issue Sep 16, 2019 · 0 comments

Comments

@a-stacey
Copy link
Contributor

a-stacey commented Sep 16, 2019

There is a lot of common code copy pasted code between services, for instance:

appMToHandler :: (HasLogging context) => context -> AppM context TrailsServiceError x -> Handler x

appMToHandler :: (HasLogging context) => context -> AppM context ORError x -> Handler x

that could be refactored easily and put in mirza-common-haskell to avoid the duplication. Further we could refactor the services so that they realy more on common code (and therefore unify the way things are handled). I had hoped to do this, but have not found the time.

@a-stacey a-stacey changed the title Deduplicate Deduplicate common code between services Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant