Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis password should be a global config in k8s #383

Open
hardbyte opened this issue Jun 7, 2019 · 0 comments
Open

Redis password should be a global config in k8s #383

hardbyte opened this issue Jun 7, 2019 · 0 comments

Comments

@hardbyte
Copy link
Collaborator

hardbyte commented Jun 7, 2019

Following this guidance, we now use a global.postgresql section so subcharts can access the postgres credentials without duplicating information. With redis we currently have to have the same password twice which isn't ideal:

redis:
  ## Note the `server` and `use_sentinel` options are ignored if provisioning redis
  ## using this chart.

  ## External redis server url/ip
  server: ""

  ## Does the external redis server support the sentinel protocol?
  use_sentinel: false

  ## Note if deploying redis-ha you MUST have the same password below!
  password: "9X9RFrRnQHcB"

redis-ha:
  ## Settings for configuration of a provisioned redis ha cluster.
  ## https://github.com/helm/charts/tree/master/stable/redis-ha
  ## Provisioning is controlled in the `provision` section
  auth: true
  redisPassword: "9X9RFrRnQHcB"

Instead we should have a global.redis section in our default values.yaml file.

@hardbyte hardbyte changed the title [k8s] Redis password should be a global config Redis password should be a global config in k8s Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant