Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add databricks_notification_destination data source #3950

Closed
mgyucht opened this issue Aug 27, 2024 · 3 comments
Closed

[FEATURE] Add databricks_notification_destination data source #3950

mgyucht opened this issue Aug 27, 2024 · 3 comments
Labels
feature New feature or request good first issue this is something simple that can help started with provider development

Comments

@mgyucht
Copy link
Contributor

mgyucht commented Aug 27, 2024

Use-cases

For users who want to make use of notification destinations that are created out-of-band or in other terraform templates, it would be convenient to add a data source for notification destinations. This would be useful in DABs for example, where notification destinations may be configured once by a workspace admin, and then used by many users in their various jobs or pipelines.

Attempted Solutions

Proposal

data databricks_notification_destinations {} # Lists all notification destinations

data databricks_notification_destinations {
  display_name = "..."
  type = "..."
}

References
@mgyucht mgyucht added the feature New feature or request label Aug 27, 2024
@alexott alexott added the good first issue this is something simple that can help started with provider development label Aug 27, 2024
@VOVELEE
Copy link
Contributor

VOVELEE commented Aug 28, 2024

Hey,

the APIs are finally released: https://docs.databricks.com/api/azure/workspace/notificationdestinations/create
I am also interested in this :)

dgomez04 added a commit to dgomez04/terraform-provider-databricks that referenced this issue Oct 3, 2024
@dgomez04
databricks#3950: added initial files for notification_destinations da…
20f612f 
…ta resource
dgomez04 added a commit to dgomez04/terraform-provider-databricks that referenced this issue Oct 3, 2024
@dgomez04
databricks#3950: added initial version of notification destination da…
05eec9c 
…ta source.
dgomez04 added a commit to dgomez04/terraform-provider-databricks that referenced this issue Oct 8, 2024
@dgomez04
databricks#3950: added integration tests to the data_notification_des…
e4aecf0 
…tinations resource
dgomez04 added a commit to dgomez04/terraform-provider-databricks that referenced this issue Oct 9, 2024
@dgomez04
databricks#3950: fixed acceptance test import
a1da23e
@dgomez04 dgomez04 mentioned this issue Oct 9, 2024
Merged
5 tasks
dgomez04 added a commit to dgomez04/terraform-provider-databricks that referenced this issue Oct 9, 2024
@dgomez04
databricks#3950: Added documentation for the data source.
5cd4114
dgomez04 added a commit to dgomez04/terraform-provider-databricks that referenced this issue Oct 14, 2024
@dgomez04
databricks#3950: migrated to the plugin framework
e080a2c
dgomez04 added a commit to dgomez04/terraform-provider-databricks that referenced this issue Oct 14, 2024
@dgomez04
databricks#3950: resolved merge conflicts
4164c4b
dgomez04 added a commit to dgomez04/terraform-provider-databricks that referenced this issue Oct 15, 2024
@dgomez04
databricks#3950: made requested changes, data source is now case-inse…
c493663 
…nsitive, and returns a list if no matches are found.
dgomez04 added a commit to dgomez04/terraform-provider-databricks that referenced this issue Oct 16, 2024
@dgomez04
databricks#3950: merged main to resolve conflcits and removed note fr…
f92b705 
…om docs
github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2024
@dgomez04 @alexott
[Feature] Add data source databricks_notification_destinations (#4087)
e24c780 
## Changes
<!-- Summary of your changes that are easy to understand -->
Added `databricks_notification_destinations` data source as requested in
#3950 to retrieve notification destinations that are created out-of-band
or in other terraform templates.
## Tests
<!-- 
How is this tested? Please see the checklist below and also describe any
other relevant tests
-->

- [x] `make test` run locally
- [x] relevant change in `docs/` folder
- [x] covered with integration tests in `internal/acceptance`
- [x] relevant acceptance tests are passing
- [x] using Go SDK

---------

Co-authored-by: Alex Ott <[email protected]>
@dgomez04
Copy link
Contributor

@mgyucht closed by #4087

@alexott
Copy link
Contributor

alexott commented Oct 18, 2024

Fixed in #4087

@alexott alexott closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request good first issue this is something simple that can help started with provider development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexott @mgyucht @VOVELEE @dgomez04