Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad support for subqueries in the FROM clause #30

Open
filipsch opened this issue Aug 13, 2018 · 1 comment
Open

Bad support for subqueries in the FROM clause #30

filipsch opened this issue Aug 13, 2018 · 1 comment
Labels

Comments

@filipsch
Copy link
Contributor

See this example on ast-viewer.datacamp.com.

A bunch of unshaped nodes.

@filipsch filipsch added the bug label Aug 13, 2018
@machow
Copy link
Contributor

machow commented Aug 14, 2018

It looks like quite a few things can go into the FROM clause in a SELECT statement. If we just want to add support for subqueries here, I think we can just handle that case in the dml_expression_clause rule in the grammar.

https://github.com/datacamp/antlr-plsql/blob/master/antlr_plsql/plsql.g4#L1293

From what I can tell the three changes are:

  1. support a list of table expressions in the FROM clause (see this query)
  2. implement some AST structure for table aliases (see this query)
  3. handle subqueries in the FROM clause (see this query)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants