Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve has_expr messaging #308

Closed
filipsch opened this issue Jul 5, 2018 · 1 comment
Closed

Improve has_expr messaging #308

filipsch opened this issue Jul 5, 2018 · 1 comment
Assignees
@filipsch
Labels
enhancement messages

Comments

@filipsch
Copy link
Contributor

filipsch commented Jul 5, 2018

  • Currently, it's showing an 'expected x but got y'-like message, even though these x and y can be huge lists. If they aren't simple strings, they should be summaries instead:
    • "Expected a list with 5 elements, but a list with 4 elements".
  • If name is set, the feedback message doesn't necessarily make sense.
  • If context values have been specified, the feedback messages don't necessarily make sense.
  • If environment variables have been specified, the feedback messages don't necessarily make sense.
@filipsch filipsch self-assigned this Jul 5, 2018
@filipsch filipsch changed the title Improve has_equal_ast messaging Improve has_expr messaging Jul 31, 2018
@filipsch
Copy link
Contributor Author

filipsch commented Aug 8, 2018

Partly done, other part is in #317

@filipsch filipsch closed this as completed Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipsch filipsch

Labels
enhancement messages
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@filipsch