Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Add support for Athena #154

Closed
johanjvrens opened this issue Jul 7, 2022 · 7 comments
Closed

Add support for Athena #154

johanjvrens opened this issue Jul 7, 2022 · 7 comments
Labels
new-db-driver Request to add a new database driver triage

Comments

@johanjvrens
Copy link

johanjvrens commented Jul 7, 2022

Hi,
Is Athena in the pipeline to be added as a Supported Databases?

Regards Johan

@johanjvrens johanjvrens changed the title P Add support for Athena Jul 7, 2022
@erezsh
Copy link
Contributor

erezsh commented Jul 13, 2022

Hi @johanjvrens ,

Athena is currently not considered a high priority, but we might implement it if the demand is high (please vote 👍🏼 for feature requests).

However, contributions are very welcome! If you'd like to try, we'll be happy to help you in the process.

@erezsh erezsh added the new-db-driver Request to add a new database driver label Jul 20, 2022
@niger-prequel
Copy link

Would love to know more about how to get this going, we're possibly open to taking it on

@erezsh
Copy link
Contributor

erezsh commented Oct 7, 2022

Hi @niger-prequel , that's great to hear.

To get started, read these:

  1. https://github.com/datafold/data-diff/blob/master/CONTRIBUTING.md

  2. https://data-diff.readthedocs.io/en/latest/new-database-driver-guide.html

Also, ideally you would add Athena to docker-compose.yml, so that docker-compose up athena would set it up to pass the tests.

If you have any questions, or need advice, feel free to ask!

@github-actions
Copy link
Contributor

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues/PRs that have gone stale label May 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2023

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

@github-actions github-actions bot closed this as completed Jun 4, 2023
@osalloum
Copy link

+1

@github-actions github-actions bot added triage and removed stale Issues/PRs that have gone stale labels Jun 24, 2023
@dwp0980
Copy link

dwp0980 commented May 9, 2024

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-db-driver Request to add a new database driver triage
Projects
None yet
Development

No branches or pull requests

5 participants