Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Commas for number output #538

Closed
kylemcnair opened this issue Apr 28, 2023 · 4 comments
Closed

Commas for number output #538

kylemcnair opened this issue Apr 28, 2023 · 4 comments
Assignees
Labels
--dbt Issues/features related to the dbt integration enhancement New feature or request in-progress stale_immune Immunity to stale bot

Comments

@kylemcnair
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In a recent data-diff, with the numbers being large, I found it a little hard to glean info.

ANALYTICS.ANALYTICS.ORG_ACTIVITY_STREAM <> DEV.DBT_DEV_KYLE.ORG_ACTIVITY_STREAM 

  Rows Added    Rows Removed
------------  --------------
        1386           86573

Updated Rows: 1558080
Unchanged Rows: 2999582

Values Updated:
ORG_NAME: 14
USER_ID: 100
CUSTOM_PROPERTIES: 86
ACTIVITY_REPEATED_AT: 504400
ORG_ID: 14
ACTIVITY: 0
EVENT_TIMESTAMP: 0
USER_EMAIL: 100
ORG_KEY: 14
ACTIVITY_OCCURRENCE: 1413643 

Describe the solution you'd like
I think formatting numbers with commas is an easy win.

Describe alternatives you've considered

  • add percentages
    • I think % everywhere can get too busy, but I think even topline % changes for row would help

This is a little more subjective and I'm gonna skip for now.

@kylemcnair kylemcnair added enhancement New feature or request --dbt Issues/features related to the dbt integration labels Apr 28, 2023
@kylemcnair kylemcnair self-assigned this Apr 28, 2023
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues/PRs that have gone stale label Jun 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2023
@dlawin dlawin reopened this Jul 5, 2023
@github-actions github-actions bot added triage and removed stale Issues/PRs that have gone stale labels Jul 5, 2023
@dlawin dlawin added stale_immune Immunity to stale bot and removed triage labels Jul 10, 2023
@dlawin
Copy link
Contributor

dlawin commented Jul 10, 2023

@kylemcnair do you still want to work on this one? If not I can take it

@dlawin dlawin assigned dlawin and unassigned kylemcnair Jul 27, 2023
@glebmezh
Copy link
Contributor

Hi @kylemcnair,

I'm sorry for the delay in following up on this. Thank you for taking the time to raise this issue!

We made a hard decision to sunset the data-diff package and won't provide further development or support.

If that's of interest, over the past few months, we have rewritten the diffing engine in Datafold Cloud and solved many issues that existed in this package.

-Gleb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
--dbt Issues/features related to the dbt integration enhancement New feature or request in-progress stale_immune Immunity to stale bot
Projects
None yet
Development

No branches or pull requests

3 participants