Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

Incorrect difference when comparing varchar key between Oracle and RDS Postgres #550

Closed
skmanchala opened this issue May 4, 2023 · 9 comments
Labels
bug Something isn't working non-dbt Use cases outside of dbt stale_immune Immunity to stale bot

Comments

@skmanchala
Copy link

Giving inaccurate differnce when comparing the varchar key value between a table in Oracle and RDS Postgres.

@skmanchala
Copy link
Author

Orgin difference shows correct , destination difference just dumps the whole key list even though they exist

@chandu-chai
Copy link

The same issue I found between Postgres and BigQuery. More details are here.

@dlawin dlawin added bug Something isn't working xdb non-dbt Use cases outside of dbt and removed xdb labels May 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues/PRs that have gone stale label Jul 8, 2023
@github-actions
Copy link
Contributor

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment and it will be reopened for triage.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 15, 2023
@skmanchala
Copy link
Author

No Worries, i have found a alternate way of finding the differences without the data-diff. The package will be of no use if it cannot follow some basic rules when comparing..

@github-actions github-actions bot added triage and removed stale Issues/PRs that have gone stale labels Jul 19, 2023
@dlawin dlawin removed the triage label Jul 19, 2023
@dlawin dlawin reopened this Jul 19, 2023
@dlawin
Copy link
Contributor

dlawin commented Jul 19, 2023

relates to #550

@dlawin
Copy link
Contributor

dlawin commented Jul 19, 2023

No Worries, i have found a alternate way of finding the differences without the data-diff. The package will be of no use if it cannot follow some basic rules when comparing..

Hey @skmanchala can you add some detail?

This is not enough to be actionable on its own:

Giving inaccurate differnce when comparing the varchar key value between a table in Oracle and RDS Postgres.
Orgin difference shows correct , destination difference just dumps the whole key list even though they exist

However this scenario may become apparent in the resolution of #550

@skmanchala
Copy link
Author

We have a Varchar primary key in both RDS Postgrest and Oracle which i am using to compare the data, as mentioned previously , the record in source not in target shows up correcly but after that it shows all the records in destination not present in source

@dlawin dlawin added stale_immune Immunity to stale bot and removed triage labels Aug 9, 2023
@glebmezh
Copy link
Contributor

Hi @skmanchala,

I'm sorry for the delay in following up on this. Thank you for taking the time to raise this issue!

We made a hard decision to sunset the data-diff package and won't provide further development or support.

If that's of interest, over the past few months, we have rewritten the diffing engine in Datafold Cloud and solved many issues that existed in this package's diffing algorithm.

-Gleb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working non-dbt Use cases outside of dbt stale_immune Immunity to stale bot
Projects
None yet
Development

No branches or pull requests

4 participants