Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

data diff hot reloading #621

Closed
sungchun12 opened this issue Jun 23, 2023 · 4 comments
Closed

data diff hot reloading #621

sungchun12 opened this issue Jun 23, 2023 · 4 comments
Assignees
Labels
--dbt Issues/features related to the dbt integration enhancement New feature or request triage

Comments

@sungchun12
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It can get tedious writing out the full command because I make slight changes to the dbt command and it slows down my pace. Arrow-keying up for command history isn't enough.
dbt run --select <MODEL> && data-diff --dbt

Describe the solution you'd like
A clear and concise description of what you want to happen.

I invoke dbt run --select <MODEL> and data-diff gets invoked automatically without ever having to write out or manually invoke the command.

  • It can run as a background process to notice changes to the run_results.json and manifest.json files to then run the diffs
  • A clever mechanism that when the compiled files are created it pokes at the data-diff process to be invoked vs. a background process polling for changes
  • Python packages that come to mind: watchdog

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

  • Build my own alias command, but then I'd have to maintain it and I'm not a fan of that

Additional context
Add any other context or screenshots about the feature request here.

I want it to look and feel like the terminal experience here: https://www.loom.com/share/ecfbdfb981e4443d94d2c95f16176118?sid=65968680-12ea-45bb-bd95-be43b19941c5

@sungchun12 sungchun12 added the enhancement New feature or request label Jun 23, 2023
@sungchun12
Copy link
Contributor Author

Happy to build this feature out myself if capacity is an issue!

@dlawin dlawin removed the triage label Jun 23, 2023
@dlawin
Copy link
Contributor

dlawin commented Jun 23, 2023

I invoke dbt run --select and data-diff gets invoked automatically without ever having to write out or manually invoke the command.

This would be awesome. In an ideal state data-diff is not adding any additional process to the development workflow, we're removing repetitive process and tedious commands.

@dlawin dlawin added the --dbt Issues/features related to the dbt integration label Jun 23, 2023
@github-actions
Copy link
Contributor

This issue has been marked as stale because it has been open for 60 days with no activity. If you would like the issue to remain open, please comment on the issue and it will be added to the triage queue. Otherwise, it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues/PRs that have gone stale label Aug 23, 2023
@sungchun12
Copy link
Contributor Author

Let's close this out because the VS Code extension has this built-in

@github-actions github-actions bot added triage and removed stale Issues/PRs that have gone stale labels Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
--dbt Issues/features related to the dbt integration enhancement New feature or request triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants