Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onRemoteConfigChange #78

Open
cheng93 opened this issue Feb 28, 2024 · 4 comments
Open

onRemoteConfigChange #78

cheng93 opened this issue Feb 28, 2024 · 4 comments
Labels
bug

Comments

@cheng93
Copy link

cheng93 commented Feb 28, 2024

The following PR #64 has removed the functionality introduced by #23. Which potentially allows seq to control the logging level.

Was this intended?
@KodrAus
Copy link
Member

KodrAus commented Feb 28, 2024

Hi @cheng93 👋 Thanks for pointing that out. That doesn't look intentional to me, so I think we should re-introduce it.

@KodrAus
Copy link
Member

KodrAus commented Feb 28, 2024

@cheng93 Were you previously using the dynamic level switching, or are you expecting to start using it?

@cheng93
Copy link
Author

cheng93 commented Feb 29, 2024

I'm looking to start using it.

I saw that it was defined in the types. https://github.com/datalust/seq-logging/blob/dev/index.d.ts#L11 So thought it was available.

See datalust/winston-seq#18

@liammclennan
Copy link
Contributor

@cheng93 this would be a nice feature for the JS clients, but it is not on our short term roadmap. We are interested in a PR.

@nblumhardt nblumhardt added the bug label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liammclennan @nblumhardt @KodrAus @cheng93