Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for changes in upstream 24 March 2020 #36

Open
1 of 2 tasks
rufuspollock opened this issue Mar 24, 2020 · 8 comments
Open
1 of 2 tasks

Refactor for changes in upstream 24 March 2020 #36

rufuspollock opened this issue Mar 24, 2020 · 8 comments
Assignees

Comments

@rufuspollock
Copy link
Member

rufuspollock commented Mar 24, 2020

There are changes upstream we need to handle (cf #33): CSSEGISandData/COVID-19#1250

  • US specific data with info by @anuveyatsu are we now pulling the US data into a separate file? If not, that would be useful i think e.g. us.csv
  • Also what other new data files or changes do we need to do?
@rufuspollock
Copy link
Member Author

cc @westmich

@westmich
Copy link

@rufuspollock Thanks for tagging me on this. Any thoughts on the why? Are they having trouble keeping up with cases or is this data getting locked down?

@anuveyatsu
Copy link
Member

One of the major changes is the removal of recovered cases (#39). On this, I'm planning to remove Recovered field from the data files (we may move it to archive directory if anybody needs it). WDYT?

@berndblasius
Copy link

Can you please leave the Recovered field in for the other countries which provide this info?
I know there are some quality issues about recovered data, but it is crucial to calculate the number of active cases.

@anuveyatsu
Copy link
Member

@berndblasius we depend on the upstream here so we can't keep it I'm afraid..

@berndblasius
Copy link

berndblasius commented Mar 26, 2020 via email

@anuveyatsu
Copy link
Member

@berndblasius they have announced that they will stop providing the recovered data sometimes soon

@rufuspollock
Copy link
Member Author

@anuveyatsu one option is for us to write out the current recovered data to a separate file here and then integrate when we do the processing so it stays around and we don't have a breaking change?

anuveyatsu added a commit that referenced this issue Mar 29, 2020
Gwardii pushed a commit to Gwardii/covid-19 that referenced this issue Mar 17, 2024
Gwardii pushed a commit to Gwardii/covid-19 that referenced this issue Mar 17, 2024
Gwardii pushed a commit to Gwardii/covid-19 that referenced this issue Mar 17, 2024
Gwardii pushed a commit to Gwardii/covid-19 that referenced this issue Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants