Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a min_score option #107

Open
bjchambers opened this issue Feb 4, 2025 · 1 comment
Open

Add a min_score option #107

bjchambers opened this issue Feb 4, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@bjchambers
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Not a problem that has arisen, but there are cases where a traversal is being performed and we are only interested in nodes above a certain score threshold.

Describe the solution you'd like
A better solution would allow us to specify the cutoff to the traversal, and then push that filter down to the vector store queries where possible. This would reduce the number of nodes being returned, and allow us to avoid considering any nodes below the threshold.

Describe alternatives you've considered
We can accomplish this today by ignoring any retrieved nodes below the threshold.

Additional context
Add any other context or screenshots about the feature request here.

@bjchambers bjchambers added the enhancement New feature or request label Feb 4, 2025
@bjchambers
Copy link
Collaborator Author

bjchambers commented Feb 5, 2025

MMR currently has this option, but it is not passed through or widely respected.

Although, for MMR this would be min_mmr_score and for other cases we have a min_similarity_score, so perhaps the MMR case should be renamed, and the other fields clarified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant