renamed MetadataDenormalizer into ShreddingTransformer #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13197993119Details
💛 - Coveralls |
Test Results 8 files ±0 8 suites ±0 2m 28s ⏱️ -3s Results for commit 2ddcf0a. ± Comparison against base commit c61b19f. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both. |
bjchambers
reviewed
Feb 7, 2025
| @@ -15,7 +15,7 @@ __Supported__ | |||
|
|
|||
| __Collection Support__ | |||
|
|
|||
| : Indicates whether the store supports lists in metadata values or not. Stores which do not support it directly (:material-alert-circle:{.yellow}) can be used by applying the [MetadataDenormalizer][langchain_graph_retriever.transformers.metadata_denormalizer.MetadataDenormalizer] document transformer to documents before writing, which spreads the items of the collection into multiple metadata keys. | |||
| : Indicates whether the store supports lists in metadata values or not. Stores which do not support it directly (:material-alert-circle:{.yellow}) can be used by applying the [ShreddingTransformer][langchain_graph_retriever.transformers.ShreddingTransformer] document transformer to documents before writing, which spreads the items of the collection into multiple metadata keys. | |||
There was a problem hiding this comment.
Should this be formatted as code (backticks)? Or should we not use them elsewhere?
| The [Adapter][graph_retriever.adapters.Adapter] interface may be implemented directly. For LangChain [VectorStores][langchain_core.vectorstores.base.VectorStore], [LangchainAdapter][langchain_graph_retriever.adapters.langchain.LangchainAdapter] and [ShreddedLangchainAdapter][langchain_graph_retriever.adapters.langchain.ShreddedLangchainAdapter] provide much of the necessary functionality. |
There was a problem hiding this comment.
It may make sense to be consistent on ShreddingTrannsformer vs. ShreddedLangchainAdapter (eg., ShreddingLangchainAdapter?)
There was a problem hiding this comment.
the adapters use already shredded documents. That is why I used Shredded instead of Shredding.
But I'll change to make consistent if you feel that is better.
| from langchain_community.document_transformers.metadata_denormalizer import ( | ||
| MetadataDenormalizer, | ||
| ) | ||
| from langchain_community.document_transformers import ShreddingTransformer |
There was a problem hiding this comment.
I do not believe this is part of langchain_community.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.