Support edges to/from nested fields #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows an edge like `("a.b", "b.c")`.
bjchambers
commented
Feb 19, 2025
| @@ -113,7 +113,11 @@ def _matches(self, filter: dict[str, Any] | None, content: Content) -> bool: | |||
| return True | |||
|
|
|||
| for key, filter_value in filter.items(): | |||
| content_value = content.metadata.get(key, SENTINEL) | |||
| content_value = content.metadata | |||
| for key_part in key.split("."): | |||
There was a problem hiding this comment.
Split keys on .. This is questionable -- some people might put a.b in the key.
bjchambers
commented
Feb 19, 2025
| @@ -273,6 +314,10 @@ class AdapterComplianceSuite(abc.ABC): | |||
| loaded. | |||
| """ | |||
|
|
|||
| def supports_nested_metadata(self) -> bool: | |||
| """Return whether nested metadata is expected to work.""" | |||
There was a problem hiding this comment.
Add some ability to create "features" that disable respective tests. Can refine later.
bjchambers
commented
Feb 19, 2025
| @@ -25,6 +28,16 @@ def adapter( | |||
| ) | |||
|
|
|||
| shredder = ShreddingTransformer() | |||
|
|
|||
| # Chroma doesn't even support *writing* nested data currently, so we | |||
There was a problem hiding this comment.
Ugh. Chroma won't even persist things with nested data.
Pull Request Test Coverage Report for Build 13423892143Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.