Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Postgres as a Source #19

Open
shubham19may opened this issue Dec 7, 2024 · 2 comments
Open

[Feat] Postgres as a Source #19

shubham19may opened this issue Dec 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@shubham19may
Copy link
Contributor

  1. CDC sync
  2. Connections tests
@shubham19may shubham19may converted this from a draft issue Dec 7, 2024
@ashujoshi20
Copy link

I reviewed the postgres.go file and noticed a potential improvement in the Check() function related to database connection management.
The db.Close() call is missing, which can lead to connection leaks during the connection test process. Adding defer db.Close() right after db = db.Unsafe() could help ensure the database connection is closed after its intended use.

@hash-data hash-data added the enhancement New feature or request label Jan 7, 2025
@hash-data
Copy link
Collaborator

hash-data commented Jan 7, 2025

Hi @ashujoshi20 we will start work on postgres driver soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants