Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme: update SASS to latest dartsass compatibility #1321

Open
4 of 7 tasks
davidsneighbour opened this issue Jan 14, 2025 · 0 comments
Open
4 of 7 tasks

theme: update SASS to latest dartsass compatibility #1321

davidsneighbour opened this issue Jan 14, 2025 · 0 comments
Assignees
@davidsneighbour
Labels
state:inprogress Work is done on this issue. Probably in main branch too. type:bug Bugfixes in codebase when something is not working. type:enhancement New enhancements and features. type:tests Issues related to tests.

Comments

@davidsneighbour
Copy link
Owner

davidsneighbour commented Jan 14, 2025 •
edited
Loading

Trying to run SASS outside of Hugo results in issues. Fixing these issues results in Hugo not building CSS anymore. Fixing that results in errors in the SASS pipeline. Maybe just do it right from the beginning ;)

  • use dartsass
  • run npm run sass and fix issues
    • replace deprecated color functions
    • replace deprecated array functions
    • replace deprecated imports for dnb particles (Bootstrap still requires them at this point apparently)
  • configure and fix Hugo setup and configuration to use dartsass
  • add workflow to test sass

Might touch some modules:
@davidsneighbour davidsneighbour added type:bug Bugfixes in codebase when something is not working. type:enhancement New enhancements and features. type:tests Issues related to tests. state:confirmed This issue is confirmed. state:inprogress Work is done on this issue. Probably in main branch too. labels Jan 14, 2025
@davidsneighbour davidsneighbour self-assigned this Jan 14, 2025
davidsneighbour added a commit to davidsneighbour/hugo-darkskies that referenced this issue Jan 14, 2025
@davidsneighbour
theme(fix): deprecated dart sass methods and running via npm (WIP)
39def1f 
see davidsneighbour/kollitsch.dev#1321

Signed-off-by: Patrick Kollitsch <[email protected]>
@davidsneighbour davidsneighbour mentioned this issue Jan 14, 2025
Merged
davidsneighbour added a commit to davidsneighbour/hugo-darkskies that referenced this issue Jan 15, 2025
@davidsneighbour
theme(fix): more fixes for deprecated sass internals
acea756 
see davidsneighbour/kollitsch.dev#1321

Signed-off-by: Patrick Kollitsch <[email protected]>
@davidsneighbour davidsneighbour removed the state:confirmed This issue is confirmed. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidsneighbour davidsneighbour

Labels
state:inprogress Work is done on this issue. Probably in main branch too. type:bug Bugfixes in codebase when something is not working. type:enhancement New enhancements and features. type:tests Issues related to tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidsneighbour