Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: dlib doesn't build with FFmpeg 7 #2986

Closed
arrufat opened this issue Jul 31, 2024 · 8 comments
Closed

[Bug]: dlib doesn't build with FFmpeg 7 #2986

arrufat opened this issue Jul 31, 2024 · 8 comments

Comments

@arrufat
Copy link
Contributor

arrufat commented Jul 31, 2024

What Operating System(s) are you seeing this problem on?

Linux (x86-64)

dlib version

19.24

Python version

No response

Compiler

GCC 14.1.1

Expected Behavior

Build dlib successfully with FFmpeg support

Current Behavior

FFmpeg broke some APIs,
There are some fields that got renamed from channel_layouts to ch_layouts.

Steps to Reproduce

git clone https://github.com/davisking/dlib
cd dlib
cmake -B build -G Ninja
cmake --build build

Anything else?

It would be great if @pfeatherstone could take a look at this, since I don't have multiple FFmpeg installations, I might fix this and break other versions...

@pfeatherstone
Copy link
Contributor

Yeah I can have a look later today

@pfeatherstone
Copy link
Contributor

I won't be able to test with gcc14 though. Best I can do 13

@arrufat
Copy link
Contributor Author

arrufat commented Jul 31, 2024

Thank you! I don't think the compiler poses a problem.

@pfeatherstone
Copy link
Contributor

I've started looking at this. I will finish this evening. I was relying on the macro FF_API_OLD_CHANNEL_LAYOUT to determine whether the new ch_layout API was available. They have now removed it so i'm working on some meta-programming to solve this. Luckily, the additions of is_detected and switch_() are proving to be useful.

@pfeatherstone
Copy link
Contributor

Meta-programming not working. I'm replacing the FFMPEG macro with a custom one. Looks like it's working.

@pfeatherstone
Copy link
Contributor

#2987

@arrufat
Copy link
Contributor Author

arrufat commented Jul 31, 2024

I can confirm it works now, thank you so much!

@davisking
Copy link
Owner

Awesome, thanks guys :D

@arrufat arrufat closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants