Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devcontainers with multiple compose.yml doesn't build in Daytona #1344

Open
divanshu-go opened this issue Nov 16, 2024 · 0 comments · May be fixed by #1349
Open

devcontainers with multiple compose.yml doesn't build in Daytona #1344

divanshu-go opened this issue Nov 16, 2024 · 0 comments · May be fixed by #1349
Labels
bug Something isn't working

Comments

@divanshu-go
Copy link
Contributor

divanshu-go commented Nov 16, 2024

Title

Devcontainers with Array of dockerComposeFile Fail to Build in Daytona

Describe the Bug

Devcontainers that use an array for the dockerComposeFile property fail to build in Daytona.

Error Message:

panic: interface conversion: interface {} is []interface {}, not string

To Reproduce

Steps to reproduce the issue:

  1. Clone and try building the following projects in Daytona:

  2. Observe the build process failing with the above error.

Expected Behavior

The projects should build successfully without errors, regardless of whether the dockerComposeFile property is defined as a string or an array.

Suggested Fixes

In Daytona:

Modify Daytona's handling of the dockerComposeFile property to support both string and array formats.

Temporary Workaround:

Update the devcontainer.json in affected projects to use a string for the dockerComposeFile property. For example:
From:

{
  "dockerComposeFile": [
    "docker-compose.yml"
  ]
}

To:

{
  "dockerComposeFile": "docker-compose.yml"
}

Screenshots

image

Desktop

  • OS: Manjaro Linux
  • Daytona Version: Branch main
@divanshu-go divanshu-go added the bug Something isn't working label Nov 16, 2024
@divanshu-go divanshu-go changed the title devcontainers with compose.yml doesn't build in Daytona devcontainers with multiple compose.yml doesn't build in Daytona Nov 16, 2024
@Tpuljak Tpuljak linked a pull request Nov 19, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant