Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all the URLs, parameters as environment variables #15

Closed
4 tasks done
Perevalov opened this issue Jul 31, 2023 · 1 comment
Closed
4 tasks done

Make all the URLs, parameters as environment variables #15

Perevalov opened this issue Jul 31, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Perevalov
Copy link
Contributor

Perevalov commented Jul 31, 2023

Context

Currently in the code all the URLs (e.g., here or here) and global parameters are hardcoded. It should be changed to environment variables. The variables to be set via dotenv if an .env file is present locally, otherwise directly imported from os.getenv("VAR_NAME").

Definition of Done

  • Check all the hardcoded parameters and URLs
  • Change the identified ones to the env variables
  • Test if everything still works as before
  • Push the code
@muskan-k
Copy link
Collaborator

muskan-k commented Aug 3, 2023

Done, tested and verified.
PR - #17
PR - #18

I've also edited the GA workflow to be triggered on pull requests to main branch as well, instead of only being triggered on merge since the best practice is check the build on PRs as a gateway to being merged.

@muskan-k muskan-k closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants