Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] dbt-snowflake adapter 1.8+ installs newer dbt-core than intended #682

Open
2 tasks done
devonlazarussonos opened this issue Jan 22, 2025 · 2 comments
Open
2 tasks done
Labels
pkg:dbt-snowflake Issue affects dbt-snowflake

Comments

@devonlazarussonos
Copy link

Is this a new bug in dbt-snowflake?

  • I believe this is a new bug in dbt-snowflake
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Installation of a dbt-snowflake 1.8+ adapter currently installs dbt-core 1.9+.

Once dbt-core 1.10+ is released, then the 1.8+ adapter will install dbt-core 1.10+ and so on.

Expected Behavior

Installation of a dbt-snowflake adapter 1.8+ installs dbt-core with the same major.minor version as the adapter.

Steps To Reproduce

  1. Setup a virtual environment
$ python3 -m venv .venv --upgrade-deps
$ . .venv/bin/activate
  1. Install any version of dbt-snowflake 1.8+
$ pip install dbt-snowflake==1.8.0
  1. Verify the installed version of dbt-core
$ pip list installed | grep ^dbt
dbt-adapters               1.13.2
dbt-common                 1.14.0
dbt-core                   1.9.1.     <<<
dbt-extractor              0.5.1
dbt-semantic-interfaces    0.7.4
dbt-snowflake              1.8.0

Note this behavior exists across all 1.8+ versions:

$ pip install dbt-snowflake==1.8.4
$ pip list installed | grep ^dbt
dbt-adapters               1.13.2
dbt-common                 1.14.0
dbt-core                   1.9.1.     <<<
dbt-extractor              0.5.1
dbt-semantic-interfaces    0.7.4
dbt-snowflake              1.8.4

Relevant log output

dbt_project.yml: `require-dbt-version: ['>=1.7.0', <1.9.0]`


$ dbt run
...
14:17:18  This version of dbt is not supported with the 'foo' package.
14:17:18  Installed version of dbt: =1.9.1
14:17:18  Required version of dbt for 'foo': ['>=1.7.0', '<1.9.0']
...

Environment

- OS: MacOS Sequoia 15.2 (Darwin Kernel Version 24.2.0)
- Python: Python 3.11.9
- dbt-core: 1.9.1
- dbt-snowflake: 1.8.0 - 1.8.4

Additional Context

This issue is hiding in dbt-snowflake 1.9+ as well.

As soon as dbt-core 1.10+ is released both 1.8+ and 1.9+ Snowflake adapters will be installing dbt-core 1.10+.

@mikealfare mikealfare added the pkg:dbt-snowflake Issue affects dbt-snowflake label Jan 22, 2025
@mikealfare
Copy link
Contributor

@devonlazarussonos We removed the requirement that dbt-core and an adapter must match to the minor in 1.8. This is a valid combination of dependencies now. Have you noticed any issues associated with this combination of dbt-core and dbt-snowflake?

@devonlazarussonos
Copy link
Author

devonlazarussonos commented Jan 22, 2025

Okay, that makes sense. I was looking through the documentation to see if that was the case, but didn't find anything.

The only risk I see is our old model of protecting from breaking changes in dbt-core no longer works.

How are you managing the risk of breaking changes in dbt-core being introduced into the ecosystem?

Although not ideal, we've seen breaking changes in minor releases of dbt-core. (Well, one actually, I think, to be fair.)

And, if we install dbt-snowflake at an inopportune moment, we'll pick up rc releases from dbt-core 1.10, right?

Have you noticed any issues associated with this combination of dbt-core and dbt-snowflake?

To answer directly, no. Just in the way we're using that require-dbt-version, which we could fix.

@mikealfare mikealfare transferred this issue from dbt-labs/dbt-snowflake Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:dbt-snowflake Issue affects dbt-snowflake
Projects
None yet
Development

No branches or pull requests

2 participants