Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [spike] Wrong commit used for core testing #104

Open
2 tasks done
emmyoop opened this issue Apr 12, 2024 · 2 comments · Fixed by #105 or dbt-labs/dbt-core#10023
Open
2 tasks done

[Bug] [spike] Wrong commit used for core testing #104

emmyoop opened this issue Apr 12, 2024 · 2 comments · Fixed by #105 or dbt-labs/dbt-core#10023
Assignees
Labels
bug Something isn't working tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 12, 2024

Is this a new bug in dbt-common?

  • I believe this is a new bug in dbt-common
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

When we put a PR into the merge queue it uses the wrong commit on dbt_common to run tests against. This is because tox reinstalls all dependencies so overriding the dep isn't working as written.

Expected Behavior

Use the temporary merge commit to run tests to mock the state after merge

Steps To Reproduce

  1. Open a Pr
  2. Add PR to merge queue
  3. observe the commit checked out for dbt-common in PR

Relevant log output

No response

Additional Context

No response

@emmyoop emmyoop added bug Something isn't working tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Apr 12, 2024
@emmyoop emmyoop self-assigned this Apr 12, 2024
@emmyoop
Copy link
Member Author

emmyoop commented Apr 22, 2024

I'm not actually sure if this is a problem. See comment in PR for more context. Going to monitor the next real merge to be sure.

@emmyoop
Copy link
Member Author

emmyoop commented May 1, 2024

This is still not working. The commit it shows in CI as the one used on the merge seems to be accurate. However, I just successfully merged a PR with passing core tests that then immediately began failing CI in dbt-core.

@emmyoop emmyoop reopened this May 1, 2024
@emmyoop emmyoop removed their assignment May 2, 2024
@graciegoheen graciegoheen changed the title [Bug] Wrong commit used for core testing [Bug] [spike] Wrong commit used for core testing May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
1 participant