Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt-core CI cannot be skipped #123

Open
1 task done
emmyoop opened this issue May 1, 2024 · 0 comments
Open
1 task done

dbt-core CI cannot be skipped #123

emmyoop opened this issue May 1, 2024 · 0 comments
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@emmyoop
Copy link
Member

emmyoop commented May 1, 2024

Housekeeping

  • I am a maintainer of dbt-common

Short description

Using the Skip Core Testing label does not trigger the tests to get skipped in [ci_dbt_core_testing.yml](https://github.com/dbt-labs/dbt-common/blob/main/.github/workflows/ci_dbt_core_testing.yml(

Acceptance criteria

When the label gets added to a PR, all core tests gets skipped

Suggested Tests

Manually tests you can skip tests.

Ensure you test the tests are skipped during merge as well.

Impact to Other Teams

None

Will backports be required?

No

Context

We need to be able to skip core tests when we're changing something like dependency pins. Since we share pins between the two repos this would make it easier to resolve the multiple PRs.

@emmyoop emmyoop added user docs tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality and removed user docs labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

1 participant