Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spec Update] Refactor dimension type_params to instead be separate CategoricalDimension and TimeDimension interfaces #51

Open
3 tasks done
Tracked by #7
callum-mcdata opened this issue May 17, 2023 · 0 comments
Open
3 tasks done
Tracked by #7

[Spec Update] Refactor dimension type_params to instead be separate CategoricalDimension and TimeDimension interfaces #51

callum-mcdata opened this issue May 17, 2023 · 0 comments
Labels
enhancement New feature or request Protocol Spec Change

Comments

@callum-mcdata
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward change to existing dbt-semantic-interfaces functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Right now having Dimension be agnostic of it's type forces us to do validation all throughout the codebase. So breaking up these into two different classes makes it a lot easier for us to break up the code!

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response
@callum-mcdata callum-mcdata added the enhancement New feature or request label May 17, 2023
@callum-mcdata callum-mcdata mentioned this issue May 17, 2023
Closed
@marcodamore marcodamore changed the title [Feature] Refactor dimension type_params to instead be separate CategoricalDimension and TimeDimension interfaces [Spec Update] Refactor dimension type_params to instead be separate CategoricalDimension and TimeDimension interfaces May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Protocol Spec Change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QMalcolm @callum-mcdata