You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have searched the existing issues, and I could not find an existing issue for this bug
Current Behavior
In its current implementation, when I try to set a comment on an Iceberg table, dbt-snowflake tries to do run the following command:
comment on table some_database.some_schema.some_table IS $$some comment$$
This command fails for Iceberg tables, with the following error:
SQL Compilation error: The table some_table is an Iceberg table. Iceberg tables should use ALTER ICEBERG TABLE commands. Please ensure the appropriate command format is used.
Expected Behavior
When a comment is set for an Iceberg table, the comment should be set using:
alter iceberg table some_database.some_schema.some_table set comment=$$some comment$$
I'd even go further and propose that the snowflake__alter_relation_comment macro should start using alter table, alter dynamic table, alter iceberg table to set comments as this approach is compatible with every type of object instead of creating yet another exception for Iceberg tables in the macro.
Steps To Reproduce
Create a model foo with table_format: iceberg, ensuring the description is populated
Is this a new bug in dbt-snowflake?
Current Behavior
In its current implementation, when I try to set a comment on an Iceberg table,
dbt-snowflake
tries to do run the following command:This command fails for Iceberg tables, with the following error:
Expected Behavior
When a comment is set for an Iceberg table, the comment should be set using:
I'd even go further and propose that the
snowflake__alter_relation_comment
macro should start usingalter table
,alter dynamic table
,alter iceberg table
to set comments as this approach is compatible with every type of object instead of creating yet another exception for Iceberg tables in the macro.Steps To Reproduce
foo
withtable_format: iceberg
, ensuring thedescription
is populateddbt run --select foo
Relevant log output
Environment
Additional Context
No response
The text was updated successfully, but these errors were encountered: